Doc clarification #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the term "container name" can be confusing and interpreted as simply the name of the container itself. What we really need to make registration work is the path of the container in the local registry. Clarify the documentation by adding a not ethat points out this potential pitfall.
|
@rjschwei as you mentioned podman images in the docs I think you could also add information how to show the images that flake is actually using. This requires the following Otherwise it lists "some" images from the user or root and this could be confusing for the user |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the term "container name" can be confusing and interpreted as simply the name of the container itself. What we really need to make registration work is the path of the container in the local registry. Clarify the documentation by adding a not ethat points out this potential pitfall.