kiwi_boxed_plugin: utils: fetch_files: improve progressbar import #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The progressbar2 module is installed on Debian-based systems as "progressbar2", and can be imported as such, but if progressbar2 has been installed from pip the module is called "progressbar". Adjust the import of this module to first try importing "progressbar2", and if it fails, fall back to "progressbar". This stops the tool from trying to import the old progressbar module rather than the correct progressbar2 module. Signed-off-by: Isaac True <[email protected]>
schaefi
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The progressbar2 module is installed on Debian-based systems as "progressbar2", and can be imported as such, but if progressbar2 has been installed from pip the module is called "progressbar". Adjust the import of this module to first try importing "progressbar2", and if it fails, fall back to "progressbar". This stops the tool from trying to import the old progressbar module rather than the correct progressbar2 module.
See the file lists in the
python3-progressbar2andpython3-progressbarpackages in Ubuntu for reference: