Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround needed for render info collection before OpenDisplay #117

Open
JeroMiya opened this issue Sep 19, 2016 · 0 comments
Open

Workaround needed for render info collection before OpenDisplay #117

JeroMiya opened this issue Sep 19, 2016 · 0 comments
Labels

Comments

@JeroMiya
Copy link
Contributor

There is a bug in the current implementation when prediction is turned on in the server config. When this happens, the RenderManager code in the render info collection API assumes the display is already open, and fails if it is not. We use this API to calculate the render target sizes, but we need to do so on the game thread, and before the display is opened (which happens later).

The real fix is to implement this issue in OSVR-Core and use the new API instead of RenderManager to calculate those render target sizes:
OSVR/OSVR-Core#316

Until then, we need to add another workaround in OSVR-Unreal that calculates render target sizes without the render info collection API. We could go back to using the DisplayConfig API to get the raw target sizes and then use our existing code that parses the render manager config to adjust them ourselves for oversample and overfill.

@JeroMiya JeroMiya added the bug label Sep 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant