Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add repository to HACS #42

Open
MadOne opened this issue Nov 16, 2024 · 9 comments
Open

Add repository to HACS #42

MadOne opened this issue Nov 16, 2024 · 9 comments
Labels
enhancement New feature or request

Comments

@MadOne
Copy link
Collaborator

MadOne commented Nov 16, 2024

Is your feature request related to a problem? Please describe.
Everyone who wants to use our integration has to find it and add it to hacs,

Describe the solution you'd like
Add our integration to hacs so everywone using hacs can find it

Describe alternatives you've considered
Leave it as is.

Additional context

All files required for the integration to run must be located inside the directory ROOT_OF_THE_REPO/custom_components/INTEGRATION_NAME/.

The kennfeld Files are NOT. Maybe all "kennfelder" in one file? A dropdown?

update info.md

https://hacs.xyz/docs/publish/start/#my-links
https://hacs.xyz/docs/publish/integration/

@MadOne MadOne added the enhancement New feature or request label Nov 16, 2024
@OStrama
Copy link
Owner

OStrama commented Nov 17, 2024

CHanged the file location and added select to config flow..

@OStrama
Copy link
Owner

OStrama commented Nov 17, 2024

All in one file would it make more difficult for users to create new files..

@MadOne
Copy link
Collaborator Author

MadOne commented Nov 17, 2024

I agree.
Maybe a template.json for local edit and send to us and one file where we define the known curves.
Dropdown with known curves and custom for the template.json.

But for now this is perfectly fine. We fullfill the requirements for beeing listed in hacs.

Do create a pull request? (You are the owner)

@OStrama
Copy link
Owner

OStrama commented Nov 17, 2024

Yes, will do. But what version should we use?

@MadOne
Copy link
Collaborator Author

MadOne commented Nov 17, 2024

The latest stable (1.0.1). Then we should wait pushing ne versions until we got merged.

@MadOne
Copy link
Collaborator Author

MadOne commented Nov 17, 2024

I see you pushed the file moves to the translation branch. Should we wait for the translaiton to finish, merge to main and publish 1.0.2 before we push to hacs?

@OStrama
Copy link
Owner

OStrama commented Nov 17, 2024

No, I can transfer them to version-1.0 and introduce it in HACS. But I have to debug finding always the right config dir before..

@OStrama
Copy link
Owner

OStrama commented Nov 20, 2024

Version 1.0.2 is out, temporarily without translation, because there was an issue that I found quite late on my production system:

Since we had to set _attr_has_entity_name = True, the names of the entities now contain the device name, too. This breaks statistics.

We have to find a solution for 1.0.3, either overloadeing _friendly_name_internal() or let the names change and do something like this as a repair step:
https://community.home-assistant.io/t/merge-statistics-of-old-entity-to-new-entity/467816/42

@MadOne
Copy link
Collaborator Author

MadOne commented Nov 24, 2024

hacs/default#2855

for easier finding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants