Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Naming issue #3

Open
denics opened this issue Jun 1, 2024 · 3 comments
Open

Naming issue #3

denics opened this issue Jun 1, 2024 · 3 comments

Comments

@denics
Copy link

denics commented Jun 1, 2024

we should find a consistent way to address the naming, i.e. we already have :
ovos-PHAL-plugin-mk2-fan-control which repo is called https://github.com/OpenVoiceOS/ovos-PHAL-plugin-mk2-v6-fan-control

and this is:
ovos-PHAL-plugin-sj201-leds in https://github.com/OVOSHatchery/ovos-PHAL-plugin-sj201-leds

and both are restricted to the devkit

@JarbasAl
Copy link
Contributor

JarbasAl commented Jun 1, 2024

#2 this one might support the production mk2

@builderjer
Copy link
Contributor

I still haven't figured out how to control the production unit without root privileges. After that, they will be combined into a single plugin

@builderjer
Copy link
Contributor

builderjer commented Jun 2, 2024

Also, the sj201 can be attached to another pi and it would no longer be a Mark2, but you would still want the plugin for the LED's.

The fan may be connected differently than the mk2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants