added validation #1
Conversation
| if platform == "SJ201LED": | ||
| return True | ||
| # Try a direct hardware check | ||
| if is_mycroft_sj201(): |
There was a problem hiding this comment.
has this been validated? not sure this plugin works at all, and if it does i think ONLY in devkit, so we need to exclude rev10 boards
There was a problem hiding this comment.
This is supposed to only allow the dev kit. I just added validation, have not tested the plugin
reference:
https://github.com/OpenVoiceOS/ovos-PHAL/blob/09f8b33460d2c785623f8b1c0ab73d50762064da/ovos_PHAL/detection.py#L5
But just noticed i2csound needs fixed for each board version.
There was a problem hiding this comment.
ovos-i2csound was fixed here
With this PR, any auto-detection that I can think of is handled.
|
@builderjer think you can look into #2 and maybe rebase this one on top? |
|
I am merging this, and will add more for the production unit soon. This at least allows detection for the dev unit. |
No description provided.