Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a PDF reporter #166

Open
PastNullInfinity opened this issue Jul 31, 2019 · 4 comments
Open

Add a PDF reporter #166

PastNullInfinity opened this issue Jul 31, 2019 · 4 comments
Labels

Comments

@PastNullInfinity
Copy link
Contributor

I'm currently working on a PDF reporter that uses an ERB template to output an html, and then call wkhtmltopdf for rendering the final file. The main reason for me was to create a nice output for the report to send via the Slack reporter, in case the amount of issues found was large.

The changes should be relatively easy to merge, the only new dependency would be wkhtmltopdf.

I'm open to discussion if anyone wants to propose a better solution

@omerlh
Copy link
Collaborator

omerlh commented Aug 6, 2019

Hey, sorry for the delay. Yes, that sounds like a great addition both to the slack reporter and as a standalone reporter.
The only concern is the image size - but unless wkhtmltopdf is a big library, I don't see any issue with it :)

@PastNullInfinity
Copy link
Contributor Author

The wkhtmltopdf binary itself is small, and a couple of dependencies for things like font support are needed. I've not checked the diff, but I think it should not be very large.

One other option would be generating the PDF using something like prawn, although creating a suitable template will be considerably more work, since it cannot use an ERB template as an input (the prawn templating module has been deprecated quite some time ago)

@omerlh
Copy link
Collaborator

omerlh commented Aug 7, 2019

Sounds good! Looking forward to seeing your PR :)

@stale
Copy link

stale bot commented Oct 6, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Oct 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants