Add Nimbus version as an environment variable #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OisinKyne
reviewed
Mar 23, 2023
nimbus/Dockerfile
Outdated
| @@ -1,6 +1,8 @@ | |||
| FROM statusim/nimbus-eth2:multiarch-v23.3.1 as nimbusbn | |||
| ARG NIMBUS_VERSION | |||
There was a problem hiding this comment.
Should/can this have a default in case it ends up unset in future?
There was a problem hiding this comment.
Yes this can have a default set, and it will be overwritten with anything that's passed through. Does this add to a maintenance overhead/ cause duplication though, as a default value is already being set in the docker-compose.yml file on line 199?
Or is this for when a user builds Nimbus directly on the CLI and forgets to pass in this argument?
|
How about we set `latest`? Seems like a safe fallback to have
On Thu, Mar 23, 2023 at 9:27 PM Eridian ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In nimbus/Dockerfile
<#116 (comment)>
:
> @@ -1,6 +1,8 @@
-FROM statusim/nimbus-eth2:multiarch-v23.3.1 as nimbusbn
+ARG NIMBUS_VERSION
Yes this can have a default set, and it will be overwritten with anything
that's passed through. Does this add to a maintenance overhead/ cause
duplication though, as a default value is already being set in the
docker-compose.yml file on line 199?
—
Reply to this email directly, view it on GitHub
<#116 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABGAHDAEQEMEFAGRZSBWQKDW5S55BANCNFSM6AAAAAAWFTJNII>
.
You are receiving this because you commented.Message ID:
<ObolNetwork/charon-distributed-validator-cluster/pull/116/review/1355676213
@github.com>
--
Oisín Kyne
|
|
@OisinKyne I've added "latest" and confirmed that it works. |
dB2510
approved these changes
Jun 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.