Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compendium attackSkill fields undefined for pistols and rifles #112

Open
OctarineSourcerer opened this issue Mar 20, 2022 · 1 comment
Open
Labels
data-entry Stuff that involves manually putting in data (or loading it from somewhere). May be tedious

Comments

@OctarineSourcerer
Copy link
Owner

A great deal of weapons in compendiums have "undefined" as their weapon skill. This causes firing them to fail, with the error TypeError: Cannot read properties of undefined (reading 'data') or TypeError: skill is undefined.

See, there's a LOT of these. Like, 332 pistols and 394 rifles with this issue. So I'm going to end up writing a script to help fix that, but leave this issue up to help anyone who comes across a similar issue when using pistols or rifles from the compendiums.

To work around this, click the "Attack Skill" dropdown, and click whichever skill you'd like to use for this. The weapon should then be usable.

Addendum: The same issue also plagues availability, but I suspect that's a less problematic issue for many, as it doesn't interfere with weapons firing

@OctarineSourcerer
Copy link
Owner Author

Extra notes: each of these weapons has data.data.name set to Common. Is that their real availability? If so, easy fix, but this needs verifying and I don't have the real data on these weapons to hand.

Next steps are write a quick script to list all the ones with this issue, and perhaps an extension of this that brings up a dialogue for each, allowing to set either attack skill or availability.

@OctarineSourcerer OctarineSourcerer added the data-entry Stuff that involves manually putting in data (or loading it from somewhere). May be tedious label Mar 22, 2022
@OctarineSourcerer OctarineSourcerer changed the title Compendium "undefined" fields Compendium attackSkill fields undefined for pistols and rifles Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data-entry Stuff that involves manually putting in data (or loading it from somewhere). May be tedious
Projects
None yet
Development

No branches or pull requests

1 participant