Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternative to tx message action fields #285

Open
marv-engine opened this issue Oct 31, 2014 · 3 comments
Open

Alternative to tx message action fields #285

marv-engine opened this issue Oct 31, 2014 · 3 comments

Comments

@marv-engine
Copy link

Rather than numbering txtypes consecutively, we could use increments of ten, or some other value. This would allow related actions to be numbered within the gaps, e.g:

  • tx20: Create Sell Offer (current Action = 1)
    • tx21: Update Sell Offer (current Action = 2)
    • tx22: Cancel Sell Offer (current Action = 3)
    • tx23: Accept Sell Offer (current tx22)
  • tx30: some other major txtype
  • tx40: some other major txtype
  • ...
@dacoinminster
Copy link
Contributor

This strikes me as a slight improvement which would be extremely painful
and time-consuming to retrofit. Sure, it would make the spec look a little
better, but I don't see any functional improvement to doing it, and I see
an immense cost.

On Fri, Oct 31, 2014 at 1:58 PM, Marv Schneider [email protected]
wrote:

Rather than numbering txtypes consecutively, we could use increments of
ten, or some other value. This would allow related actions to be numbered
within the gaps, e.g:

  • tx20: Create Sell Offer (current Action = 1)
    • tx21: Update Sell Offer (current Action = 2)
    • tx22: Cancel Sell Offer (current Action = 3)
    • tx23: Accept Sell Offer (current tx22)
      • tx30: some other major txtype
  • tx40: some other major txtype
  • ...


Reply to this email directly or view it on GitHub
#285.

@marv-engine
Copy link
Author

It would provide a way to eliminate fields that don't apply to the particular action, as well as isolate message changes associated with one action. I hadn't thought about making the spec look better.

@dexX7
Copy link
Member

dexX7 commented Oct 31, 2014

I support this idea and imho it's not too late nor painful, time-consuming or costly. Of course this can only be applied for not-yet-on-mainnet-transactions for now.

At the moment tx 20 and 22 are in use - for coin/token transactions. Token/token transactions could move into the 10, 30, 40, 60, 70, 80 ... range and this would be consistent with the rest of the spec, because every "class" has it's own range.

And also +1 for removing action fields whenever possible - 4 byte for [version] and [type] provide an abundant amount of potential slots that are very likely never going to be filled completely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants