Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Meta DEx: cancel-everything -- limited to ecosystem? #290

Closed
dexX7 opened this issue Dec 1, 2014 · 2 comments
Closed

Meta DEx: cancel-everything -- limited to ecosystem? #290

dexX7 opened this issue Dec 1, 2014 · 2 comments

Comments

@dexX7
Copy link
Member

dexX7 commented Dec 1, 2014

It's not specified, if "cancel-everything" cancels all offers or only those for a given ecosystem.

The discussion started here mastercoin-MSC/mastercore#219.

I think this needs clarification.
@dexX7 dexX7 mentioned this issue Dec 1, 2014
Closed
@dacoinminster
Copy link
Contributor

From mastercoin-MSC/mastercore#219:

Well, changing the code is more than trivial - it affects not just the spec and code, but also RPC interface. When the code gets ahead of the spec I tend to go with the code unless there is an obvious problem with the way it was implemented. Perhaps this slightly violates the "sandbox" intention of Test MSC, but I'd point out that most testing is now taking place on testnet, so we probably shouldn't care.

That said, if the devs want to change this for some reason, I have no objection to changing the spec too.

@dexX7
Copy link
Member Author

dexX7 commented Feb 13, 2015

Addressed by #292.

@dexX7 dexX7 closed this as completed Feb 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dacoinminster @dexX7