Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix grammar #27

Closed
jbampton opened this issue May 25, 2021 · 20 comments · Fixed by #31
Closed

Fix grammar #27

jbampton opened this issue May 25, 2021 · 20 comments · Fixed by #31
Labels
Good First Issue Good for newcomers

Comments

@jbampton
Copy link
Member

No description provided.

@jbampton jbampton added the Good First Issue Good for newcomers label May 25, 2021
@jbampton jbampton self-assigned this May 25, 2021
@BaseMax
Copy link
Member

BaseMax commented May 25, 2021

If someone is Good/Native at English, it's your chance to fix grammar and typo problems at grammar.BNF file.

@jbampton jbampton removed their assignment May 25, 2021
@BaseMax
Copy link
Member

BaseMax commented May 25, 2021

@n4i9kita, You can solve this issue now?

@n4i9kita
Copy link
Contributor

Yes, I am trying it now.
If I can, I will inform you.

@n4i9kita
Copy link
Contributor

Can you please explain what this means ?
Is it that 'it is not required for small programs and runnable scripts' ?

@BaseMax
Copy link
Member

BaseMax commented May 25, 2021

Sorry for the delay. Can you link to the line you mentioned?
I don't know are you talk about which line.

@BaseMax
Copy link
Member

BaseMax commented May 25, 2021

@n4i9kita
Copy link
Contributor

yes

@BaseMax
Copy link
Member

BaseMax commented May 25, 2021

Usually when someone want to create a library and package, we have to define package name at first line of main file.

package main
package libName
package foo

But generally, we not need to define package.

So it is only used when you want to design a library or package.

@n4i9kita
Copy link
Contributor

Ok. Thanks for explaining.

@n4i9kita
Copy link
Contributor

In line 33, line 56 and line 85,does the <second term> has 's' because of syntax or it is a grammatical mistake ?
Line 33 -
<function_arguments> ::= <function_arguments> "," <function_argument>
Shoudn't it be ?
<function_arguments> ::= <function_argument> "," <function_argument>

Please confirm.

@BaseMax
Copy link
Member

BaseMax commented May 25, 2021

function_arguments is not function_argument

<***> it's BNF name and not English word.

They are name/key of BNF grammar. not english.

@BaseMax
Copy link
Member

BaseMax commented May 25, 2021

Just to be clear: if you change keys name, so you have to do for all other place where called that key name.

@n4i9kita
Copy link
Contributor

There were 2-3 spelling errors in the key names. I have just corrected that.

@BaseMax
Copy link
Member

BaseMax commented May 25, 2021

Thanks Nikita.

@n4i9kita
Copy link
Contributor

Please review the pr.
Also, can I work on some other issue now ?

@BaseMax
Copy link
Member

BaseMax commented May 25, 2021

Thanks, done.

Also, can I work on some other issue now ?

Yes; Are you a programmer? can you introduce yourself too?

What programming language have you worked with?

@n4i9kita
Copy link
Contributor

Yes.
I am pursuing my BTech in Computer Science and Eng. at IIT Varanasi, India. I have completed my 2nd yr at college a few days back, and that's when I started with Open Source Contributions. I made my first contribution to Sympy ( library in python), and 2nd one is yours. :)
I think, I am proficient in C++ and Python and have majorly worked with these two, and am familiar with C, Kotlin and Flutter.

@BaseMax
Copy link
Member

BaseMax commented May 25, 2021

Invitation send. welcome.

@BaseMax
Copy link
Member

BaseMax commented May 25, 2021

If you would like to help to Mission Statement. it's really very good. #30
After that, we can work together on core and technical part. @n4i9kita

@n4i9kita
Copy link
Contributor

Sorry for the delay.
I read #30 .
Yes, I would like to help as much as I can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants