Merge pull request #1170 from marclucraft/main

[Fix] Replace deprecated CSS 'push-button'. Adds type='button' to Custom Link Prompt.
OneSignal · Apr 17, 2024 · 5c4c81e · 5c4c81e
2 parents 0b7ff68 + b3d802a
commit 5c4c81e
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/src/page/stylesheets/reset.scss b/src/page/stylesheets/reset.scss
@@ -490,7 +490,7 @@
   font-family: arial, helvetica, sans-serif;
   font-size: small;
   background: white;
-  -webkit-appearance: push-button;
+  appearance: button;
   color: buttontext;
   border: 1px #a6a6a6 solid;
   background: lightgrey; /* Old browsers */

diff --git a/src/shared/managers/CustomLinkManager.ts b/src/shared/managers/CustomLinkManager.ts
@@ -114,6 +114,10 @@ export class CustomLinkManager {
         await this.handleClick(subscribeButton);
       });
 
+      // Adds type="button" to the Custom Link Button.
+      // This prevents this button submitting if included in a form.
+      subscribeButton.setAttribute('type', 'button');
+
       element.appendChild(subscribeButton);
     }
   }