All parameter schema's unecessarily have "minItems": 0.0

[soxofaan]

While comparing the VITO and EODC process listings for openEOPlatform/documentation#11 I noticed that all parameter/return schemas have a "minItems": 0.0 field, e.g.

    {
      "id": "absolute",
      "parameters": [
        {
          "name": "x",
          "schema": {
            "minItems": 0.0,
            "type": ["number", "null"]
          }
        }
      ],
      "returns": {
        "schema": {
          "minItems": 0.0,
          "type": ["number", "null"]
        }
      },

As far as I know jsonschema, minItems only makes sense for arrays (and it should be an integer, not float)

[m-mohr]

As far as I know jsonschema, minItems only makes sense for arrays (and it should be an integer, not float)

Yes, indeed.

I guess the default needs to be removed:

openeo-eodc-driver/services/processes/processes/schema.py

Line 207 in 822dbd3

minItems = fields.Float(default=0, attribute='min_items')

[sophieherrmann]

Yes we set a default as defined in the api. But I can remove it.

[m-mohr]

The default value in the API means that this is the value to be used if it is not provided (in the backend response), but you provide it explicitly, which is not the desired behavior. Would be good to remove it.

[sophieherrmann]

Makes sense, I already have a fix for this. I plan to bring it to dev today and then to prod as soon as possible.

[sophieherrmann]

Fix is deployed in production, checkout https://openeo.eodc.eu/v1.0/processes

[soxofaan]

Just curious: where did you fix this? There doesn't seem to be any recent updates on https://github.com/Open-EO/openeo-eodc-driver/branches

[sophieherrmann]

We moved our backend development to our private gitlab server.