New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

load_collection for FetchType.POINT needs to be updated #106

Closed

VincentVerelst opened this issue May 7, 2024 · 1 comment

Labels

wontfix

Collaborator

VincentVerelst commented May 7, 2024 •

edited

Loading

Currently, when a user specifies FetchType.POINT, the spatial_extent of the collection is set equal to the provided FeatureCollection of points:

openeo-gfmap/src/openeo_gfmap/fetching/commons.py

Line 115 in 3bd6a0e

spatial_extent=spatial_extent,

Currently, this works on the VITO backend, but it will be updated in the future to comply with the OpenEO spec: Open-EO/openeo-geopyspark-driver#768.

Proposed solution:

Do not filter on any spatial_extent when loading in the collection
Perform all necessary processing/feature computation
To extract the points, perform an aggregate_spatial with the geometry equal to the original FeatureCollection of Points

Collaborator Author

VincentVerelst commented Jun 11, 2024

Possibly no need for an update, see Open-EO/openeo-processes#502

VincentVerelst added the wontfix label

VincentVerelst closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment