Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up legacy job listing code paths #337

Open
soxofaan opened this issue Dec 6, 2024 · 1 comment
Open

Clean up legacy job listing code paths #337

soxofaan opened this issue Dec 6, 2024 · 1 comment

Comments

@soxofaan
Copy link
Member

soxofaan commented Dec 6, 2024

Follow-up ticket of #332 and Open-EO/openeo-geopyspark-driver#959 where I added support for pagination in batch job listing.
I tried to keep original, non-paginated code paths and behavior as this exercise spans multiple components and projects, so a migration path with backward compatibility is required. Once all components are migrated and everything works properly, the old code paths should be eliminated for the sake of keeping technical debt low here.

I marked various places to consider with TODO #332 in python driver

❯ rg "TODO #332"
openeo_driver/backend.py
391:    # TODO #332 just implement as frozen dataclass, or does that conflict with later need to subclass?
461:        # TODO #332 settle on returning just `JobListing` and eliminate other options/code paths.

openeo_driver/jobregistry.py
152:        # TODO #332 settle on returning just `JobListing` and eliminate other options/code paths.
616:        # TODO #332 avoid duplication of this default field set
665:        # TODO #332 settle on returning just `JobListing` and eliminate other options/code paths.
678:            # TODO #332 make this the one and only code path
693:            # TODO #332 eliminate this code path

openeo_driver/views.py
899:        # TODO #332 settle on receiving just `JobListing` here and eliminate other options/code paths.
902:            # TODO #332 make this the one and only code path when all `get_user_jobs` implementations are migrated
905:            # TODO #332 remove support for this old API
908:        # TODO #332 while eliminating old `get_user_jobs` API above, also just settle on JobListing based return,

and TODO #959 in geopyspark driver:

openeogeotrellis/job_registry.py
695:        # TODO #959 settle on returning just `JobListing` and eliminate other options/code paths.
964:            # TODO #959 Settle on just handling JobListing and drop other legacy code path
@soxofaan
Copy link
Member Author

soxofaan commented Dec 6, 2024

FYI: this ticket is blocked on first migrating the aggregator (which also depends on python driver):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant