Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download CSV's #16

Closed
ghost opened this issue Nov 2, 2022 · 5 comments
Closed

Download CSV's #16

ghost opened this issue Nov 2, 2022 · 5 comments

Comments

@ghost
Copy link

ghost commented Nov 2, 2022

Should people be able to download all the CSV's for any data pages?

Flattentool already makes them on disk for us, so it's just a case of exposing them in the interface.

See #15 - if they can upload, download makes sense

@duncandewhurst
Copy link
Contributor

Yes please!

ghost pushed a commit that referenced this issue Nov 7, 2022
@duncandewhurst
Copy link
Contributor

duncandewhurst commented Nov 8, 2022

Looks good on the test server. Can we offer both the individual CSVs and a zip file containing all the CSVs?

That way, users who want to download just one file can do so without needing to unzip the archive, and users who want to download all the files can do so without clicking on each individual file.

image

Edit: Please name the compressed file data.zip. Thanks!

ghost pushed a commit that referenced this issue Nov 8, 2022
@ghost
Copy link
Author

ghost commented Nov 8, 2022

Can we offer both the individual CSVs and a zip file containing all the CSVs?

On 2022-11-08 branch

ghost pushed a commit that referenced this issue Nov 8, 2022
ghost pushed a commit that referenced this issue Nov 8, 2022
@duncandewhurst
Copy link
Contributor

Looks good. There's one outstanding change from my previous comment:

Edit: Please name the compressed file data.zip. Thanks!

@duncandewhurst
Copy link
Contributor

Please name the compressed file data.zip. Thanks!

This is done on live - closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant