Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GeoJson -> Json conversion: If there is inconsistent dereferenced networks/phases/organisations, report on that #26

Open
odscjames opened this issue Nov 7, 2022 · 4 comments
Open

GeoJson -> Json conversion: If there is inconsistent dereferenced networks/phases/organisations, report on that #26

odscjames opened this issue Nov 7, 2022 · 4 comments
Assignees
@odscjames

Comments

@odscjames
Copy link
Collaborator

Spun of from #25
@odscjames odscjames changed the title GeoJson -> Json conversion: If there is inconsitent dereferenced data, report on that GeoJson -> Json conversion: If there is inconsistent dereferenced data, report on that Nov 9, 2022
odscjames added a commit that referenced this issue Nov 9, 2022
@odscjames
geojsontojson: Add inconsistent information to meta
cd113f7 
#26
@odscjames
Copy link
Collaborator Author

Library checks for phases and organisations in progress, networks will be more difficult due to some recursive elements so leaving till later.

@odscjames odscjames mentioned this issue Nov 9, 2022
Open
@odscjames odscjames self-assigned this Nov 9, 2022
odscjames added a commit that referenced this issue Nov 9, 2022
@odscjames
geojsontojson: Add inconsistent information to meta
7e7386a 
#26
odscjames added a commit that referenced this issue Nov 25, 2022
@odscjames
geojsontojson: Report on inconsistent networks
abc3121 
#26

tests/fixtures/geojson_to_json/phases_inconsistent*:
Added new inconsistent phrase in contract in network
Make sure the phase_id is reported in meta output
odscjames added a commit that referenced this issue Nov 25, 2022
@odscjames
geojsontojson: Report on inconsistent networks
cad4463 
#26

tests/fixtures/geojson_to_json/phases_inconsistent*:
Added new inconsistent phrase in contract in network
Make sure the phase_id is reported in meta output
@odscjames
Copy link
Collaborator Author

Network checking is now in the latest version of this lib. This can be tested by running the tool locally and looking in the meta file, or just looking at the "expected" files in https://github.com/Open-Telecoms-Data/lib-cove-ofds/tree/main/tests/fixtures/geojson_to_json

We'll let Open-Telecoms-Data/cove-ofds#30 deal with reporting these to the user - if the meta/expected files look good we could close this?

@duncandewhurst
Copy link
Contributor

I think we might need some more information to help users locate the issues. I've prepared a conversion checks spreadsheet to try and specify these checks, the necessary metadata and the feedback to users. Let me know what you think!

@odscjames
Copy link
Collaborator Author

I've moved the spreadsheet to Open-Telecoms-Data/cove-ofds#30 as that's where reporting these to the user is being dealt with.

Edited title to keep this issue on track for networks/phases/organisations.

Todo:

  • provide more information when a problem occurs

@odscjames odscjames changed the title GeoJson -> Json conversion: If there is inconsistent dereferenced data, report on that GeoJson -> Json conversion: If there is inconsistent dereferenced networks/phases/organisations, report on that Dec 1, 2022
@odscjames odscjames mentioned this issue Dec 1, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@odscjames odscjames

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@duncandewhurst @odscjames