Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unique ID checks (show all error occurences) #51

Open
odscjames opened this issue Nov 29, 2022 · 4 comments
Open

Unique ID checks (show all error occurences) #51

odscjames opened this issue Nov 29, 2022 · 4 comments

Comments

@odscjames
Copy link
Collaborator

I've realised while putting these into the Cove UI that

  • if a ID is used 3 times we want one error for that ID (currently you will get 2 errors)
  • You want to see the path for each time the user ID is used (currently you won't see the first path, only subsequent ones)
@duncandewhurst
Copy link
Contributor

duncandewhurst commented Nov 30, 2022

I think it might be better to show 3 errors, that way there is only one ID and path per error, which is consistent with all the other error types.

@odscjames
Copy link
Collaborator Author

Moved heading error to Open-Telecoms-Data/cove-ofds#64 - deleted from comment above

@duncandewhurst
Copy link
Contributor

duncandewhurst commented Dec 7, 2022

Edit: Ignore me, it was a different check.

@duncandewhurst duncandewhurst changed the title Unique ID checks; don't report multiple times & report multiple paths Unique ID checks (show all error occurences) Dec 7, 2022
odscjames added a commit that referenced this issue Dec 20, 2022
@odscjames
Copy link
Collaborator Author

I think it might be better to show 3 errors, that way there is only one ID and path per error, which is consistent with all the other error types.

That will just start happening next time we release a version of this library and update cove to use it (already tested).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants