Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add uniqueness rule for .name fields #172

Open
duncandewhurst opened this issue Nov 6, 2022 · 0 comments
Open

Add uniqueness rule for .name fields #172

duncandewhurst opened this issue Nov 6, 2022 · 0 comments
Labels

Comments

@duncandewhurst
Copy link
Collaborator

duncandewhurst commented Nov 6, 2022

From Open-Telecoms-Data/cove-ofds#6 (comment):

.phase.name, .status.name, etc, anything .name - could 2 items have different id's but very similar names or even exactly the same names? There isn't a rule for unique names.

I don't think we can enforce unique names using JSON schema, but we could add a rule as part of the field descriptions. I think the rule should be a should rather than a must. Making it a must would mean the name was effectively a unique identifier, and we don't know what edge cases might exist for non-unique names.

Edit: If we add this rule, we can add an additional check to https://github.com/Open-Telecoms-Data/lib-cove-ofds

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant