Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

towncrier changed parse_toml API #105

Open
pllim opened this issue Oct 15, 2020 · 2 comments
Open

towncrier changed parse_toml API #105

pllim opened this issue Oct 15, 2020 · 2 comments
Assignees
@Cadair

Comments

@pllim
Copy link
Contributor

pllim commented Oct 15, 2020

Takes 2 positional arguments now. So when this is released, baldrick gonna break.

https://github.com/twisted/towncrier/blob/3d01a194a68f48d49f66ff1f29d49e73cdf90dc2/src/towncrier/_settings.py#L78
@Cadair Cadair self-assigned this Oct 15, 2020
@pllim
Copy link
Contributor Author

pllim commented Apr 6, 2021

Ah... I think we're seeing this now.

parse_toml() missing 1 required positional argument: 'config'

@pllim
Copy link
Contributor Author

pllim commented Apr 6, 2021

I don't think it is worth it to even use what they have now. I ended up copy-paste their code and undid the new API. I tried to pin but I think they deleted the tag where it used to work... I can't find 19.1 in their releases! 20.x and 18.x both broke things in different ways.

https://github.com/pllim/actions-towncrier-changelog/blob/9dc06e9d89f93b089545087d3b960fc04b095ae0/check_changelog.py#L50-L140

@pllim pllim mentioned this issue Apr 6, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Cadair Cadair

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Cadair @pllim