New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix python source distributions builds #360

Merged

kdewald merged 3 commits into OpenBluetoothToolbox:main from tlifschitz:fix-python-sdist-version

Nov 14, 2024

Contributor

tlifschitz commented Nov 6, 2024

Problem:

The Python dev versioning logic assumed that setup.py was being executed inside a Git repository, causing an exception when building from source outside of Git
A missing file in the MANIFEST caused the build to fail

Changes in this PR:

Update setup.py to modify the VERSION file content during source distribution generation, appending the dev version if needed. This ensures consistency with the version in published wheels
Updates setup.py to fall back on the VERSION file content if Git commands fail
Adds the missing files to the MANIFEST

tlifschitz added 3 commits

November 6, 2024 01:43


          Append dev version only if running in git

13a61e4


          Fix missing file in manifest made sdist builds fail

883b882


          Fix dev versioning in sdist

c0af9e4

kdewald merged commit df4ec85 into OpenBluetoothToolbox:main

11 of 13 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet