feat: added combobox, get documentstore, validate documentstore #38

ChenRen93 · 2021-07-08T07:00:30Z

Added combo box for document store input
Retrieve all the documents store created by the wallet
Validate if the document store belongs to the wallet

Closes #34 , Closes #36

netlify · 2021-07-08T07:00:40Z

✔️ Deploy Preview for new-admin-opencerts ready!

🔨 Explore the source changes: 4ce9ee1

🔍 Inspect the deploy log: https://app.netlify.com/sites/new-admin-opencerts/deploys/611ca65fe168d900079e4b77

😎 Browse the preview: https://deploy-preview-38--new-admin-opencerts.netlify.app/

src/components/common/text-input.tsx

src/components/util/document-store.tsx

lgtm-com · 2021-07-13T03:26:07Z

This pull request introduces 2 alerts when merging f2576a6 into 5395197 - view on LGTM.com

new alerts:

2 for Unused variable, import, function or class

Nebulis · 2021-07-19T08:10:47Z

src/components/util/document-store.tsx

+
+export const isDocumentStore = async (documentStoreAddress: string): Promise<boolean> => {
+  const documentStoreArray = await getDocumentStores();
+  documentStoreArray.filter((documentStore) => {


I don't think we should only allow document stores we retrieved. What if we missed some?

you didn't address this ...

I not using isDocumentStore to validate the contract anymore, thus removing the function. I using isValidContract() located in common.tsx. The function checks if the address is a contract using getCode that get blockTag block height, If the address is not a contract, the result return is 0x

Reference
https://docs.ethers.io/v5/single-page/#/v5/api/providers/provider/-%23-Provider-getCode

src/components/common/text-input.tsx

Nebulis · 2021-07-19T08:39:36Z

src/components/util/document-store.tsx

@@ -0,0 +1,39 @@
+import { connectWallet, getWalletNetwork } from "./wallet";
+
+export const getDocumentStores = async (): Promise<Array<Record<string, unknown>>> => {


how do you test? It doesn't look like it work at all for me.

My wallet: https://ropsten.etherscan.io/address/0xB26B4941941C51a4885E5B7D3A1B861E54405f90

the document store retrieved

All the document stores are less than 63 days old + I didn't create that many in the last 2 months

i found 100 contract creation log for "0xB26B4941941C51a4885E5B7D3A1B861E54405f90" wallet
https://ropsten.etherscan.io/txs?a=0xB26B4941941C51a4885E5B7D3A1B861E54405f90&f=5&p=1

If you search 0xcae (first in the screenshot) You wont find it in the link you shared. I also can't find a document store:

You can try with my wallet if you want. The information are shared in a spreadsheet

found the issue. fixed. The logs topic is only capturing address "0xc84b0719a82626417c40f3168513dfabdb6a9079". i have change it to get logs based on the wallet address

I have no document store anymore

mmm weirdly it works for mine.

ok I see some doc store, but I can't find https://ropsten.etherscan.io/address/0x8Fc57204c35fb9317D91285eF52D6b892EC08cD3

what about u ?

0x8Fc57204c35fb9317D91285eF52D6b892EC08cD3 seems to be a very different from the current contract, it is using the older contract version.

Based on my checks, it is currently retrieving the contracts that are of the current version, this feature will cause an issue if there is an upgrade on the upcoming/future contracts refactoring. i believe it is not worth continuing the feature of getting a document store as there isn't a simpler way to retrieve the past document store.

If u are okay with it, I will remove the retrieval of the document store and combo box but keep the document store validation just by checking the hashes length. This MR is getting huge, it will be preferable if i could get this merged into master before I change it to the localStorage implementation.

Nebulis · 2021-07-19T08:44:30Z

src/components/common/text-input.tsx

+  };
+
+  return (
+    <Creatable


Can't use arrows

What do u mean by can't use arrows

try to navigate with arrows

fixed. The issue is cause useEffect continuous looping recreating the dropdown. I have fixed it by running useEffect only once

Nebulis · 2021-07-19T08:49:01Z

package.json

@@ -41,6 +41,7 @@
    "@types/node": "^15.12.2",


Read the other comments but overall I don't think it's worth continuing on this. Doesn't look like a simple way t do what I suggested unless you want to dig further.

We can keep the part that verifies it's a valid address

Let me know what you think.

lgtm-com · 2021-07-22T12:17:47Z

This pull request introduces 1 alert when merging c896eaa into 4e6761b - view on LGTM.com

new alerts:

1 for Unused variable, import, function or class

Nebulis · 2021-08-24T04:50:45Z

src/components/store-deploy-block.tsx

@@ -1,13 +1,15 @@
-import React, { Dispatch, FunctionComponent, useState } from "react";
-import { TextInput } from "./common/text-input";
+declare let window: any;


dont put ts definitions in ts code

you completely delete all the provided typings :)

Nebulis · 2021-08-24T04:52:03Z

src/components/header.tsx

@@ -41,7 +41,7 @@ export const Header: FunctionComponent = () => {
        getWalletDetails();
      }
    }
-  });
+  }, []);


u should remove the listeners

Nebulis · 2021-08-24T04:52:43Z

src/components/store-deploy-block.tsx

+        getDocumentStoreList();
+      }
+    }
+  }, []);


remove listeners

feat: added combobox, get documentstore, validate documentstore

1dcabbe

fix: bypass document store check for dappateer

10131cf

Nebulis reviewed Jul 9, 2021

View reviewed changes

ChenRen93 added 4 commits July 12, 2021 10:05

fix: rename validate docstore

ddd61ea

chore: added comments

5dff2c3

feat: change datalist to react-select

b0b77d2

Merge branch 'master' into feat/retrieve-and-validate-documentstore

f2576a6

fix: lint and test case

43c3b69

Nebulis reviewed Jul 19, 2021

View reviewed changes

src/components/common/text-input.tsx Show resolved Hide resolved

Nebulis reviewed Jul 19, 2021

View reviewed changes

ChenRen93 added 4 commits July 22, 2021 18:50

fix: update retrieval document store

5290b8c

fix: run useEffect only once

6d00696

fix: run useEffect once

ecaef28

fix: check if address is valid ERC20 token

c896eaa

ChenRen93 added 4 commits August 18, 2021 13:04

fix: fixing lint and remove isDocumentStore

3a99406

fix: remove getWalletNetwork import

eec06e5

fix: added dappteer changes for isValidContract

47f545e

fix: update onconnect and change get document store

4ce9ee1

Nebulis reviewed Aug 24, 2021

View reviewed changes

src/components/store-deploy-block.tsx

getDocumentStoreList();

}

}

}, []);

Copy link

Nebulis Aug 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove listeners

ChenRen93 closed this Aug 24, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: added combobox, get documentstore, validate documentstore #38

feat: added combobox, get documentstore, validate documentstore #38

ChenRen93 commented Jul 8, 2021 •

edited

Loading

netlify bot commented Jul 8, 2021 •

edited

Loading

lgtm-com bot commented Jul 13, 2021

Nebulis Jul 19, 2021

Nebulis Aug 18, 2021

ChenRen93 Aug 18, 2021

Nebulis Jul 19, 2021

ChenRen93 Jul 21, 2021 •

edited

Loading

Nebulis Jul 22, 2021

ChenRen93 Jul 22, 2021 •

edited

Loading

Nebulis Aug 18, 2021

ChenRen93 Aug 18, 2021

Nebulis Aug 24, 2021

ChenRen93 Aug 24, 2021 •

edited

Loading

Nebulis Jul 19, 2021

ChenRen93 Jul 21, 2021

Nebulis Jul 22, 2021

ChenRen93 Jul 22, 2021

Nebulis Jul 19, 2021

lgtm-com bot commented Jul 22, 2021

Nebulis Aug 24, 2021

Nebulis Aug 24, 2021

Nebulis Aug 24, 2021

		@@ -0,0 +1,39 @@
		import { connectWallet, getWalletNetwork } from "./wallet";

		export const getDocumentStores = async (): Promise<Array<Record<string, unknown>>> => {

feat: added combobox, get documentstore, validate documentstore #38

feat: added combobox, get documentstore, validate documentstore #38

Conversation

ChenRen93 commented Jul 8, 2021 • edited Loading

netlify bot commented Jul 8, 2021 • edited Loading

lgtm-com bot commented Jul 13, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ChenRen93 Jul 21, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ChenRen93 Jul 22, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ChenRen93 Aug 24, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lgtm-com bot commented Jul 22, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ChenRen93 commented Jul 8, 2021 •

edited

Loading

netlify bot commented Jul 8, 2021 •

edited

Loading

ChenRen93 Jul 21, 2021 •

edited

Loading

ChenRen93 Jul 22, 2021 •

edited

Loading

ChenRen93 Aug 24, 2021 •

edited

Loading