Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Symfony DI container instead of service factories #1762

Open
phavekes opened this issue Nov 29, 2024 · 2 comments
Open

Use Symfony DI container instead of service factories #1762

phavekes opened this issue Nov 29, 2024 · 2 comments

Comments

@phavekes
Copy link
Member

This issue is imported from pivotal - Originaly created at Jan 24, 2017 by Alex Rothuis

Currently there are some services that are being built in EngineBlock_Corto_Module_Services.

EngineBlock Corto services tend to extend EngineBlock_Corto_Module_Service_Abstract, services created using a factory do not extend this class because they have their own special needs. By using the Symfony DI container and YML files, each service can be configured in their own specific way.

@phavekes
Copy link
Member Author

Already fixed this in 5.7? (Michiel Kodde - Jul 2, 2018)

@phavekes
Copy link
Member Author

Making Corto use Symfony-DI 100% is not doable. The mentioned case could be fixed. Todo: see what can be done / what the benefits are. (bstrooband - Jul 19, 2018)

@phavekes phavekes removed their assignment Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant