Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OPR] Show review progress to the user #1247

Open
2 tasks done
jh-RLI opened this issue Jun 7, 2023 · 3 comments · May be fixed by #1386
Open
2 tasks done

[OPR] Show review progress to the user #1247

jh-RLI opened this issue Jun 7, 2023 · 3 comments · May be fixed by #1386
Assignees

Comments

@jh-RLI
Copy link
Contributor

jh-RLI commented Jun 7, 2023

  • indicate open fields in tab with little dot
  • indicate overall progress with percentage
@jh-RLI jh-RLI changed the title Show review progress to the user [OPR] Show review progress to the user Jun 7, 2023
@jh-RLI jh-RLI moved this to Todo in Open Peer Review Jun 7, 2023
jh-RLI added a commit that referenced this issue Jun 26, 2023
@jh-RLI
Copy link
Contributor Author

jh-RLI commented Jul 20, 2023

dots have been implemented in #1275
-> currently they will just update if the submit button is clicked, this will change soon.

@Darynarli
Copy link
Contributor

@jh-RLI
The percentage should indicate how much of the field has the "ok" state when a contributor or reviewer responds. Or should it dynamically calculate the percentage when a reviewer is reviewing, or when a contributor agrees/disagrees with the reviewer's suggestions?

@jh-RLI
Copy link
Contributor Author

jh-RLI commented Oct 6, 2023

It should be calculated dynamically. You can start by including only the static ok fields that are available after submitting to have a first result. In the end it would be confusing if the percentage is not updated immediately when the ok button is clicked :)

I can also imagine that there might be a java script library that does just that. Then you would only have to define which values have to be checked. A short google search might be worthwhile. But maybe this is too specific and you have to develop it yourself.

@Darynarli Darynarli linked a pull request Oct 6, 2023 that will close this issue
5 tasks
@Darynarli Darynarli linked a pull request Oct 6, 2023 that will close this issue
5 tasks
mdvcode pushed a commit that referenced this issue Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
3 participants