Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate docker build and first startup test #1853

Open
1 task done
ebroda opened this issue Sep 20, 2024 · 1 comment
Open
1 task done

Integrate docker build and first startup test #1853

ebroda opened this issue Sep 20, 2024 · 1 comment

Comments

@ebroda
Copy link
Contributor

ebroda commented Sep 20, 2024

Description of the issue

There sometimes issues with the docker image and it's build process which are introduced as things change and the docker generation and startup process is not always tested by the devs.

Ideas of solution

Include an automated github check, at least for merge requests, which builds the docker image and trys to start it. If the image hasn't thrown error after like a minute (which is probably enough to test it), then this can be assumed as passed.

Alternatively, try to do a get on localhost:8080, which should succeed when the container started successful.

I'm not sure of how to do that, but probably there's a CI way to do that.

Workflow checklist

@jh-RLI
Copy link
Contributor

jh-RLI commented Nov 26, 2024

Good idea, i would have to look into it again but i set up similar things in the past. Maybe it is better to go the alternative way you suggested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants