Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PeerReview improvements #1800

Open
wants to merge 21 commits into
base: develop
Choose a base branch
from
Open

PeerReview improvements #1800

wants to merge 21 commits into from

Conversation

Darynarli
Copy link
Contributor

Summary of the discussion

During testing of the review process, some errors were found, and ideas were also generated on how to make the review process clearer and easier for users:

  1. Change the functionality of the "Deny" button
  2. Comments on an accepted field
  3. Peer Review "delete" button
  4. Bugs on Summary Tab
  5. Modifying an accepted field

Type of change (CHANGELOG.md)

Features

  • Add a new functionality (#)

Changes

  • Update existing functionality (#)

Bugs

  • Fixed a problem with (#)

Removed

  • Remove a broken link (#)

Documentation updates

  • Updated documentation for (#)

Workflow checklist

Automation

Closes #1798

PR-Assignee

Reviewer

  • 🐙 Follow the Reviewer Guidelines
  • 🐙 Provided feedback and show sufficient appreciation for the work done

@Darynarli Darynarli linked an issue Aug 19, 2024 that may be closed by this pull request
PeerReview Process improvements #1798
Open
1 task
user and others added 20 commits August 19, 2024 18:07
Fix the bug that causes the same field to be displayed twice #1798
e49ead5
fixed bug with processing of fields with state suggest/deny and statu…
8003765 
…s missing #1798
bugs fixed:
861c471 
display of empty fields on the page of a participant with two statuses;
 display after submitting reviewed fields (suggest/deny status) on the summary page as missing #1798
function for deleting fields with state rejected #1798
2c7af07
updated metadata with removing rejected fields functionality for Peer…
149b4db 
…Review & Table tables #1798
updated functionality to complete review #1798
827c6d4
valuearea is not required for deny button #1798
b68c2cd
change status Missing for Pending on submit page #1798
f87562a
display pending for contributing fields on submit page #1798
c2f7483
disable ok/deny buttons for reviewer's rejected fields #1798
8036255
Active ok button without page reload for unreviewed fields #1798
16d5ef6
remove value suggestions on an accepted field #1798
e6af1e9
Using recursive_update function with deletion of rejected fields to u…
ac9a199 
…pdate metadata #1798
updated recursive_update function to remove rejected fields and overw…
52be6ce 
…rite suggested values #1798
add field add_comment to update metadata #1798
61213f9
add displaying field add_comment for rejected fields;
a2443c7 
 add new button Save comments #1798
add displaying field add_comment for rejected fields;
b577f81 
 add new button Save comments #1798
save new field add_comment for rejected state fields to review_data #…
4e052e4 
…1798
update CHANGELOG.md #1798
5f2b8d6
@jh-RLI
Merge branch 'develop' into feature/1798-peerreview-process-improvements
499d16e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PeerReview Process improvements
2 participants
@Darynarli @jh-RLI