Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: should we autoinstall by default? #589

Closed
josephjclark opened this issue Feb 6, 2024 · 1 comment · Fixed by #594
Closed

CLI: should we autoinstall by default? #589

josephjclark opened this issue Feb 6, 2024 · 1 comment · Fixed by #594

Comments

@josephjclark
Copy link
Collaborator

I want to say YES!

But the autoinstall process is actually quite slow (see #137 ).

I think that's because the CLI shells out to npm to tell if the adaptor has been installed. Maybe there's a quicker way we can do that to speed the CLI up.

The 1.0 release is a great time to make a change like this. Maybe it's better to automatically but slowly autoinstall and do a patch release later to speed it up

@github-project-automation github-project-automation bot moved this to New Issues in v2 Feb 6, 2024
@josephjclark
Copy link
Collaborator Author

I think the answer is YES. I'll have a quick look at the performance but if it takes more than an hour I'll a patch a fix later

@github-project-automation github-project-automation bot moved this from New Issues to Done in v2 Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant