Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Worker: maybe waiting forever for null dataclips? #590

Closed
josephjclark opened this issue Feb 8, 2024 · 1 comment
Closed

Worker: maybe waiting forever for null dataclips? #590

josephjclark opened this issue Feb 8, 2024 · 1 comment

Comments

@josephjclark
Copy link
Collaborator

I need to investigate this.

Runs might be getting lost because the worker is asking lightning for a null dataclip, and getting an error or crickets back, and maybe generally waiting forever.

TODO:

  • check the timeout on load dataclip
  • check the error handling on load dataclip
  • ensure we don't try to fetch falsy values
@github-project-automation github-project-automation bot moved this to New Issues in v2 Feb 8, 2024
@josephjclark
Copy link
Collaborator Author

Two quick learnings:

  • the worker only asks for dataclips if initialState is a string. I suppose '' could be a value
  • There is no error handling on the getDataClip (and getCredential) channel, so we do need to beef that up

@josephjclark josephjclark moved this from New Issues to In review in v2 Feb 9, 2024
@github-project-automation github-project-automation bot moved this from In review to Done in v2 Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

1 participant