Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collections fix version lookup #816

Merged

Conversation

josephjclark
Copy link
Collaborator

Short Description

If you specify the collections versions number (as I do in local testing), everything works fine.

But if the worker looks up the latest collections version from npm, everything breaks!

This is because:

a) I am saving the adaptor version to the wrong place so it doesn't get used (whoops)
b) the version number includes whitespace, which breaks the autoinstall command.

AI Usage

Please disclose how you've used AI in this work (it's cool, we just want to know!):

  • Code generation (copilot but not intellisense)
  • Learning or fact checking
  • Strategy / design
  • Optimisation / refactoring
  • Translation / spellchecking / doc gen
  • Other
  • I have not used AI

You can read more details in our Responsible AI Policy

Release branch checklist

Delete this section if this is not a release PR.

If this IS a release branch:

  • Run pnpm changeset version from root to bump versions
  • Run pnpm install
  • Commit the new version numbers
  • Run pnpm changeset tag to generate tags
  • Push tags git push --tags

Tags may need updating if commits come in after the tags are first generated.

@josephjclark josephjclark changed the base branch from main to release/collections-next November 8, 2024 11:52
@josephjclark josephjclark merged commit 0372fd9 into release/collections-next Nov 8, 2024
1 of 2 checks passed
@josephjclark josephjclark deleted the collections-fix-version-lookup branch November 8, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant