Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't show logs in the failure reports by default #2663

Open
christad92 opened this issue Nov 13, 2024 · 0 comments
Open

Don't show logs in the failure reports by default #2663

christad92 opened this issue Nov 13, 2024 · 0 comments

Comments

@christad92
Copy link

Adding the logs of a failed run (step) to a failure alert email potentially poses a security risk or a breach of data protection agreements as sensitive information might be logged during the run.

We should make it configurable such that users can toggle adding logs to the failure alerts via the project settings page.

@josephjclark suggested that we reference the actual error in the email but do not show all the logs. In this case, turning on the logs in failure alerts option will now let all users see logs in the email.

When Add logs to failure alerts is enabled, we should show a warning to users saying "Logs may include sensitive information".

@christad92 christad92 moved this to Backlog in v2 Nov 13, 2024
@christad92 christad92 added this to v2 Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

No branches or pull requests

1 participant