Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should we still reference Perses in showcase notebook? #165

Open
atravitz opened this issue Oct 9, 2024 · 1 comment
Open

should we still reference Perses in showcase notebook? #165

atravitz opened this issue Oct 9, 2024 · 1 comment
Labels
documentation Improvements or additions to documentation

Comments

@atravitz
Copy link
Contributor

atravitz commented Oct 9, 2024

When I first ran the showcase notebook without any contextual knowledge, I was confused as to why behavior was described as "Perses-like", since the Perses homepage comes with a big "under development" disclaimer.

I now understand that OpenFE borrowed from Perses, but for a new user I think this is more distracting than it is helpful. I suggest we rephrase or remove these references for the sake of clarity.

@atravitz atravitz added the documentation Improvements or additions to documentation label Oct 9, 2024
@IAlibay
Copy link
Member

IAlibay commented Oct 9, 2024

I think rephrasing would be good, but we need a good way to acknowledge our peers whose work we use in OpenFE. This would be a really good thing to bring up at the next protocol devs meeting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants