Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AO-898: Fix for viewing requisition view page offline #193

Merged
merged 2 commits into from
Nov 6, 2024
Merged

AO-898: Fix for viewing requisition view page offline #193

merged 2 commits into from
Nov 6, 2024

Conversation

saleksandra
Copy link
Contributor

Task:
https://openlmis.atlassian.net/browse/AO-898
Changes:

  • Added requisition groups cache,
  • Fix passing parameter to hasRoleWithRightForProgramAndSupervisoryNode function
  • Retrieving facility data from facilityService instead of localStorage for requisition cache

@saleksandra saleksandra self-assigned this Nov 6, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 6, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
10.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@DominikNoga DominikNoga merged commit 42ef2cd into master Nov 6, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DominikNoga DominikNoga DominikNoga approved these changes

Assignees

@saleksandra saleksandra

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saleksandra @DominikNoga