Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle onConflict setting for include elements related to application config #412

Open
cherylking opened this issue Sep 13, 2023 · 1 comment

Comments

@cherylking
Copy link
Member

When gathering application names and locations from Liberty config files, they are added to a common collection with no regard to the onConflict setting for the <include> element that referenced the Liberty config file. The elements that are gathered from the Liberty config files are:

  • XPATH_SERVER_APPLICATION = xPath.compile("/server/application");
  • XPATH_SERVER_WEB_APPLICATION = xPath.compile("/server/webApplication");
  • XPATH_SERVER_ENTERPRISE_APPLICATION = xPath.compile("/server/enterpriseApplication");

The methods that would need to query the onConflict setting and honor it are ServerConfigDocument.parseIncludeVariables and ServerConfigDocument.parseInclude. Also, the parseInclude method should probably call parseNames on the included file, just as it was called on the original config file in initializeAppsLocation. When merging multiple app elements for the same app, the id attribute is what connects them. Our code does not consider that attribute currently.

@cherylking
Copy link
Member Author

cherylking commented Sep 13, 2023

See this doc describing the onConflict attribute. And this doc describes the merging behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant