Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Maven jdk toolchain config in dev mode #1630

Open
scottkurz opened this issue Jan 20, 2023 · 2 comments
Open

Support Maven jdk toolchain config in dev mode #1630

scottkurz opened this issue Jan 20, 2023 · 2 comments
Labels

Comments

@scottkurz
Copy link
Member

scottkurz commented Jan 20, 2023

Parallel to OpenLiberty/ci.gradle#792, add support for Maven toolchains https://maven.apache.org/plugins/maven-toolchains-plugin/ to independently set the JDK used to run Maven itself vs. the JDK used to run other goals, most importantly (but not exclusively) the Liberty server.

See discussion especially here.

Some dimensions to the problem:

  • Honor the configuration of the toolchain plugin itself for plugin goal invocation
  • Honor configuration of individual plugins with jdk toolchain config, for executing goals of those plugins
  • Honor the config when dev mode executes a Java/JDK invocation outside of executing maven plugins,e.g. when we do the javac recompile in Maven dev mode.

The last is perhaps debatable? So maybe a bit of design thought is needed before proceeding.

@scottkurz scottkurz changed the title Support Maven toolchains in dev mode Support Maven jdk toolchain config in dev mode Jan 21, 2023
@bmarwell
Copy link
Contributor

I would be happy to create a PR once there is a user request (please 👍🏻 if you would like to see it).

@scottkurz
Copy link
Member Author

I would be happy to create a PR once there is a user request (please 👍🏻 if you would like to see it).

Sorry I didn't respond to this before. If/whenever you still have the time and interest, that would be great. I would be happy to collaborate on this.

We actually did get a request just recently:
#1781

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Target feature release
Development

No branches or pull requests

2 participants