Update to LCLS 2.2 #530
Merged
Update to LCLS 2.2 #530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adam Wisniewski <[email protected]>
mezarin
reviewed
Dec 2, 2024
| @@ -25,7 +25,7 @@ | |||
| </parent> | |||
|
|
|||
| <properties> | |||
| <liberty.ls.version>2.1.2</liberty.ls.version> | |||
| <liberty.ls.version>2.2</liberty.ls.version> | |||
There was a problem hiding this comment.
This change is good, but you also need to update:
- ci/scans/dependency-only-mend-pom.xml. It also looks like you need to update the mp.ls version in this file also.
- While you are at it, you can also update the LSP4Jakarta version to the latest. One was created last week.
There was a problem hiding this comment.
Hey @mezarin - I'm going to look into the MP and Jakarta LS versions in another issue/PR. The dependency pom also needs a bit of a rework, so have another todo for that.
There was a problem hiding this comment.
ok sounds good. Approving since the requested updates are going in a separate PR.
mezarin
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested on Eclipse 2024-09