fixed window executable tested with streamlit v1.29.0 #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Arslan-Siraj
commented
Mar 11, 2024
•
Arslan-Siraj
commented
- test with v1.29
- SIRIUS export not available in executable
- run subprocess in workflow in window .exec has problem (did not went into details)
Arslan-Siraj
changed the title
axelwalter
reviewed
Mar 11, 2024
src/workflow/StreamlitUI.py
Outdated
| @@ -375,10 +375,16 @@ def input_TOPP( | |||
| # write defaults ini files | |||
| ini_file_path = Path(self.parameter_manager.ini_dir, f"{topp_tool_name}.ini") | |||
| if not ini_file_path.exists(): | |||
|
|
|||
| # in local mode the TOPP tools in bin | |||
| if st.session_state.location == "local": | |||
There was a problem hiding this comment.
This will only apply to the Windows packages. But the app can be run in local mode using streamlit run command. Then TOPP tools might be located somewhere else.
There was a problem hiding this comment.
yeah agree with you.
how should fixed then I think the TOPP Tools should placed in same directory so will work for both.
or should create other mode (this will more prefer for me)?
There was a problem hiding this comment.
because there are many things to change while executable, if we add other mode.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.