Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bezier curve around mid symbol of dashed line #2064

Open
mlerjen opened this issue May 3, 2022 · 5 comments · May be fixed by #2099
Open

Bezier curve around mid symbol of dashed line #2064

mlerjen opened this issue May 3, 2022 · 5 comments · May be fixed by #2099
Labels
bug

Comments

@mlerjen
Copy link
Contributor

mlerjen commented May 3, 2022

Steps to reproduce

  1. Checking out the ISOM 517 Ruined Fence symbol I noticed a bump around the mid symbol see screencast below. What I do is moving the handle first, than switching to 516 Fence and back to 517.
2022-05-03-13-27-03.mp4

Just some strange behaviour, isn't it? - BTW it is the same for 514 Ruined wall.

Configuration

Mapper Version: master v20220316.2
Operating System: Windows 7
@lpechacek
Copy link
Member

Good catch. I confirm that any kind of mid-symbol causes disturbances on the dashed line.

@lpechacek lpechacek added the bug label May 3, 2022
@lpechacek
Copy link
Member

Another example. The mid symbol is a dot smaller than the line width. The rendering glitches disturb the line segment shape.
image

@dl3sdo
Copy link
Member

dl3sdo commented Oct 1, 2022

The issue can easily be reproduced by just drawing a circle with ISOM 517 Ruined Fence.

However, the issue depends on the 'Mid symbols placement' setting:
CenterOfDashesVsDashGroups

@dl3sdo
Copy link
Member

dl3sdo commented Oct 3, 2022

When borderlines are applied these look really weird (setting: center of dashes):
DashesWithMidSymbolsAndBorderlines

@dl3sdo
Copy link
Member

dl3sdo commented Oct 13, 2022

Reducing the line width to e.g., 0.01mm, shows that the mid symbols 'interrupt' the curve instead of being attached to it:

WithMinLineWidth

dl3sdo added a commit to dl3sdo/mapper that referenced this issue Oct 13, 2022
@dl3sdo
LineSymbol: Fix dashed line with mid symbols
1fb5008 
Dashed lines with mid symbols that are placed in the center of a dash
are sometimes disturbed.
This commit ensures that the dash is always drawn the same way,
independent of whether mid symbols are present or not.
Fixes OpenOrienteering#2064
@dl3sdo dl3sdo linked a pull request Oct 13, 2022 that will close this issue
Open
dl3sdo added a commit to dl3sdo/mapper that referenced this issue Dec 10, 2024
@dl3sdo
LineSymbol: Fix dashed line with mid symbols
44dfe2a 
Dashed lines with mid symbols that are placed in the center of a dash
are sometimes disturbed.
This commit ensures that the dash is always drawn the same way,
independent of whether mid symbols are present or not.

Closes OpenOrienteeringGH-2064 (Bezier curve around mid symbol of dashed line).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

LineSymbol: Fix dashed line with mid symbols dl3sdo/mapper
3 participants
@lpechacek @dl3sdo @mlerjen