Colorpicker "Pick Screen Color" Does Not Work

[kaihilbourne]

UPDATE: Looks like this is an issue with the imported QColorDialog widget:
Here is the documentation for QColorDialog: https://doc.qt.io/qtforpython-5/PySide2/QtWidgets/QColorDialog.html#PySide2.QtWidgets.PySide2.QtWidgets.QColorDialog
Describe the bug:
When trying to select a color using the "Pick Screen Color", the color picked does not match anything, and the cursor is not tracked outside of the colorpicker window.

Steps to reproduce the behavior:

1. Apply the ChromaKey video effect to one of your clips. Alternatively, pick another effect that uses a color as a property. The color picker seems to be broken, not Chromakey.
2. Right click on the effect icon added to the clip and open "Properties"
3. Open the colorpicker menu by right-clicking the "Key Color" property.
4. Choose "Pick Screen Color" and move your mouse around. You should see that the number tracking the position of the cursor stops updating when you leave the pop-up window. Also, the color selected once you click to select does not seem to correspond to an actual color you have clicked.

Expected behavior:
Once "Pick Screen Color" has been selected, the large color selection box (bottom middle) should show the exact color that the cursor is hovering over.
Additionally, the cursor should be tracked outside of the pop-up window so that you can select colors from your preview window, which I expect is the intended purpose of this tool. The color should be tracked everywhere, not just inside of OpenShot.
Once a left-click happens, the color should be locked in to the color value from underneath the cursor.

System Details:

• OpenShot Version 3.2.1-dev
• Operating System / Distro: Ubuntu 24.04.1

[kaihilbourne]

I am attempting to work on this, and will post progress updates here as well as questions.

[Colorjet3]

Hello @kaihilbourne I have assigned this to @jonoomph and also submitted this in the queue as a bug to be looked at.

[kaihilbourne]

Looks like someone else has encountered this bug with QColorDialog:
https://github.com/pyqtgraph/pyqtgraph/issues/2161

[kaihilbourne]

I've found a solution that seems to work, but it may not work with the rest of the app. The fix was to remove the QColorDialog.DontUseNativeDialog option. I believe this means that the pop-up will come from the OS instead of using an OS agnostic pop-up. This worked for me locally, but I have a feeling this fix is not the look that we are going for.

The code change is in openshot-qt/src/windows/color_picker.py and is just removing line 44 and 57, where options is set and used to set the options for the Color Dialog.

This is the pop-up for Ubuntu 24.04.1.

[Colorjet3]

Hello @kaihilbourne Please go to openshot.org/download/#daily and get the latest dev daily build available. I tested this in my Windows 11 Pro environment and I had no issues with the Color Picker.

I don't have a stable Ubuntu 24.04 environment to test in so I'll wait for your results.