Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better integrate osbv1 with homepage/osbv2 #30

Open
2 of 3 tasks
pgleeson opened this issue Oct 18, 2023 · 6 comments
Open
2 of 3 tasks

Better integrate osbv1 with homepage/osbv2 #30

pgleeson opened this issue Oct 18, 2023 · 6 comments
Assignees

Comments

@pgleeson
Copy link
Member

pgleeson commented Oct 18, 2023

Adding here as these cross the various repos...

@pgleeson pgleeson self-assigned this Oct 18, 2023
@pgleeson
Copy link
Member Author

@filippomc I've made some changes on https://github.com/OpenSourceBrain/redmine/tree/development, which I believe should go to https://beta.opensourcebrain.org/ first before depoloyment to master. Would it be possible to reenable auto deployment to beta on commit to development for testing purposes?

@filippomc
Copy link
Collaborator

That wouldn't suffice as long as docker-redmine-osb points to redmine master -- see https://github.com/SilverLabUCL/docker-redmine-osb/blob/9219706d801b43d95d21b6a410f122fffa39b9cb/assets/build/install.sh#L41C112-L41C127. We can modify the script in order to use a variable, not a big deal but let's discuss exactly the different combinations of what we might need.

A one-off alternative would be to change the line above to use the development branch and push the change do docker-redmine-osb development branch

@pgleeson
Copy link
Member Author

Understood. I've merged the change into redmine master, so can you start a manual redeploy on beta? If all goes well I'll add a few more changes on master and the liver version can be rebuilt

@filippomc
Copy link
Collaborator

@pgleeson deployment to beta done.

@pgleeson
Copy link
Member Author

@filippomc I'm seeng the updates successfully at v1, but not beta.

@filippomc
Copy link
Collaborator

didn't update due to a racing condition in pod resources. Updated now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants