Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider some node tooling #20

Open
slifty opened this issue Apr 13, 2021 · 1 comment
Open

Consider some node tooling #20

slifty opened this issue Apr 13, 2021 · 1 comment

Comments

@slifty
Copy link
Contributor

slifty commented Apr 13, 2021

Oh node, how we love thee.

In my work on #11 I'm moving the project to type: "module" which lets us do things like export foo() in a utility file.

Since it never hurts to move into modern node, I'd like to propose we consider:

  1. Adding babel
  2. Adding eslint (we have eslint in the project, though it is not clear when or how to run it
  3. Adding tests (I'm most familiar with jest)

Once we do this we can consider adding some CI to invoke the linter + tests before allowing a PR to merge. This will all be especially useful as we consider #18

@slifty
Copy link
Contributor Author

slifty commented Apr 13, 2021

Adding Babel will also make the eventual move to TypeScript easier 😈

slifty added a commit that referenced this issue Apr 13, 2021
This activates the built in module mode.  It's a step in the right ES6
direction without going full-blown babel (see issue #20).

Specifically this will allow us to use `import` and `export`
hawkinsw added a commit to hawkinsw/SimpleBook that referenced this issue May 1, 2021
1. Slowly begin migrating code to Typescript from raw Javascript
2. Instead of relying on built-in node module bundling, use webpack

These are prerequisites (in a very yak-shaving way) for adding unit
testing to the code via Jest. See
OpenTechStrategies#20.
hawkinsw added a commit to hawkinsw/SimpleBook that referenced this issue May 4, 2021
1. Slowly begin migrating code to Typescript from raw Javascript
2. Instead of relying on built-in node module bundling, use webpack

These are prerequisites (in a very yak-shaving way) for adding unit
testing to the code via Jest. See
OpenTechStrategies#20.
hawkinsw added a commit to hawkinsw/SimpleBook that referenced this issue May 4, 2021
1. Slowly begin migrating code to Typescript from raw Javascript
2. Instead of relying on built-in node module bundling, use webpack
3. Add a `yarn watch` command that will rebuild mw2pdf when any TS
   file is edited.

These are prerequisites (in a very yak-shaving way) for adding unit
testing to the code via Jest. See
OpenTechStrategies#20.
hawkinsw added a commit to hawkinsw/SimpleBook that referenced this issue May 5, 2021
1. Slowly begin migrating code to Typescript from raw Javascript
2. Instead of relying on built-in node module bundling, use webpack
3. Add a `yarn watch` command that will rebuild mw2pdf when any TS
   file is edited.

These are prerequisites (in a very yak-shaving way) for adding unit
testing to the code via Jest. See
OpenTechStrategies#20.
hawkinsw added a commit to hawkinsw/SimpleBook that referenced this issue May 5, 2021
1. Slowly begin migrating code to Typescript from raw Javascript
2. Instead of relying on built-in node module bundling, use webpack
3. Add a `yarn watch` command that will rebuild mw2pdf when any TS
   file is edited.

These are prerequisites (in a very yak-shaving way) for adding unit
testing to the code via Jest. See
OpenTechStrategies#20.
hawkinsw added a commit to hawkinsw/SimpleBook that referenced this issue May 5, 2021
1. Slowly begin migrating code to Typescript from raw Javascript
2. Instead of relying on built-in node module bundling, use webpack
3. Add a `yarn watch` command that will rebuild mw2pdf when any TS
   file is edited.

These are prerequisites (in a very yak-shaving way) for adding unit
testing to the code via Jest. See
OpenTechStrategies#20.
hawkinsw added a commit to hawkinsw/SimpleBook that referenced this issue May 5, 2021
1. Slowly begin migrating code to Typescript from raw Javascript
2. Instead of relying on built-in node module bundling, use webpack
3. Add a `yarn watch` command that will rebuild mw2pdf when any TS
   file is edited.

These are prerequisites (in a very yak-shaving way) for adding unit
testing to the code via Jest. See
OpenTechStrategies#20.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant