Fix font paths #27
Merged
Fix font paths #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hawkinsw
approved these changes
Apr 30, 2021
Fonts were being loaded in a way that would only work if the script was being called from the mw2pdf root (the folder containing the embedded fonts). This adds some (ugly) logic to identify the `__dirname` of the utility script and access fonts relative to the utility itself as opposed to the calling path. This logic is necessary because unfortunately NodeJS doesn't populate __dirname when module mode is enabled. See: https://stackoverflow.com/questions/32705219/nodejs-accessing-file-with-relative-path/32707530#32707530 As discussed in #24 we will eventually want to remove fonts from the project altogether, instead trying to have a generic default settings and allowing font configuration to be configurable for anybody who would like to override that generic option. Issue #24
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the way fonts are loaded into the PDF generation script so that their paths are no longer relative to where the script is called from
Resolves #24