-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal: adding metadata to dialog files #56
Comments
I like the idea, but with more and more metadata added, does it increase the overhead? or not enough to matter? I am not exactly clear how much processing power the metadata from here, and from utterances and ... actually take. I know with c++ pointers it wouldn't be noticeable at all, but with python, I just don't know. |
We can revisit everything about this if we want, so leave nothing on the table. I am in favor of replacing certain components with compiled funbits, but that’s getting into a broader discussion that I was hoping would wait until the upstream/downstream situation is settled in writing. Edit: the dialog renderer would be a good place for me to put my money where my mouth is in that regard |
I would propose refactoring this to keep it in sync with the dialog: dialog.yaml - name: hello
dialog:
- hi {{name}}
- hello, {{name}}
persona: {}
- name: goodbye
... In the "old style", this would have been |
this is jsonl, each line is valid json, doesnt really work well with yaml IMHO... I also quite like that we get a direct translation into a python dict, im not a fan of yaml in general, dont want to rehash this talk but more on yaml vs json has been said in linked issue above |
For the record, all JSON is valid YAML. The reverse is not true. If we support YAML, anybody who prefers JSON can just keep using it. |
updated initial comment to clarify what is being proposed is |
I had missed that, but still not sure I like json as a format for things one might edit/override in a terminal/text editor (as you said, we've been down that road before). On the other hand, this is probably sufficiently complex enough that we could justify a utility to generate the output so a skill author doesn't miss any params and to guide them through providing enough alternative utterances for different personas |
I agree with Daniel above, on all counts. I also think a utility could work just as well for a YAML/JSON solution, however, which would be as thoroughly accessible as I can imagine. |
Problems being solved
"thank you"
, you say"obrigado"/"obrigada"
"increase sarcasm by 20%"
Dialog Json
New file format,
.jsonl
, where each line in the file contains a json of the formatjsonl format info: https://jsonlines.org
Personality Settings
in mycroft.conf users can tweak personality
weights reflect how likely a dialog is to be selected
How it works
.jsonl
file if it exists, else old.dialog
filemycroft.conf
.jsonl
filereferences
previous discussions
The text was updated successfully, but these errors were encountered: