Skip to content
This repository has been archived by the owner on Aug 6, 2020. It is now read-only.

./node_modules/web3-eth-accounts/src/scrypt.js Critical dependency: the request of a dependency is an expression #41

Open
abcoathup opened this issue Dec 29, 2019 · 4 comments

Comments

@abcoathup
Copy link
Contributor

Running the client npm start in the client directory gives the following warning:

Compiled with warnings.

./node_modules/web3-eth-accounts/src/scrypt.js
Critical dependency: the request of a dependency is an expression

Search for the keywords to learn more about each warning.
To ignore, add // eslint-disable-next-line to the line before.

Checking dependencies:

$ npm ls web3-eth-accounts
[email protected] /c/Users/andre/Documents/projects/forum/starter/client
└─┬ [email protected]
  └─┬ [email protected]
    └── [email protected]

The issue is apparently resolved in [email protected] according to: web3/web3.js#3018

@nivida
Copy link

nivida commented Jan 6, 2020

@abcoathup Yes, this got already fixed and released but be aware to update your package-lock file :)

@nventuro
Copy link
Contributor

This should be fixed with #35 and #36. @abcoathup can you check?

@abcoathup
Copy link
Contributor Author

@nventuro
Copy link
Contributor

Ohh I missed the fact that we have a direct dependency. I think we can safely update it though.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants