Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass failed build error data back in heartebeat #9

Open
dowdt opened this issue Aug 6, 2024 · 0 comments
Open

Pass failed build error data back in heartebeat #9

dowdt opened this issue Aug 6, 2024 · 0 comments

Comments

@dowdt
Copy link
Contributor

dowdt commented Aug 6, 2024

This way the user can be notified what error occurred and (if they're savvy with nix) they might be able to fix it.

The simple version of this would just be displaying the failed Nix build error log.

To implement:

  • Add "last build error" field to heartbeat (Encoded as base64 or compressed pls).
  • Add "is failed build" field to the heartbeat (Should be possible since failed builds shouldn't restart the admin service).

Undecided if this should be reflected in the dpl status at all.
Undecided if we should only post once and send this as a notification instead. (Dpl notifications are currently not implemented).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant