Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(protocol-designer): dropdown option text refinement #17151

Merged
merged 6 commits into from
Dec 20, 2024

Conversation

jerader
Copy link
Collaborator

@jerader jerader commented Dec 19, 2024

closes RQA-3773 and RQA-3774

Overview

Refine the dropdown option text for module, labware, and new location.

Test Plan and Hands on Testing

Review the text for module steps, transfer/mix, and move labware

Screenshot 2024-12-19 at 13 10 28 Screenshot 2024-12-19 at 13 10 47 Screenshot 2024-12-19 at 13 11 03

Changelog

  • add prop to DropdownMenu to include a subtext and the deck label
  • plug in new text for the selectors

Risk assessment

low

@jerader jerader marked this pull request as ready for review December 19, 2024 18:11
@jerader jerader requested review from a team as code owners December 19, 2024 18:11
@jerader jerader requested review from mjhuff, koji and ncdiehl11 and removed request for a team and mjhuff December 19, 2024 18:11
protocol-designer/src/ui/labware/utils.ts Outdated Show resolved Hide resolved
protocol-designer/src/ui/modules/utils.ts Outdated Show resolved Hide resolved
protocol-designer/src/ui/modules/utils.ts Show resolved Hide resolved
@jerader jerader requested a review from ncdiehl11 December 19, 2024 21:18
Copy link
Collaborator

@ncdiehl11 ncdiehl11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jerader jerader merged commit efac75b into edge Dec 20, 2024
36 checks passed
@jerader jerader deleted the pd_dropdown-text-refinement branch December 20, 2024 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants