From c03e6f65224a482eb60b316eefb72e49902c23ad Mon Sep 17 00:00:00 2001 From: taimoor ahmad <139589712+taimoor-at-opslevel@users.noreply.github.com> Date: Wed, 13 Sep 2023 17:57:52 -0400 Subject: [PATCH 1/4] Create pull_request_template.md --- .github/pull_request_template.md | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) create mode 100644 .github/pull_request_template.md diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md new file mode 100644 index 00000000..e2697d55 --- /dev/null +++ b/.github/pull_request_template.md @@ -0,0 +1,21 @@ +## TL;DR + + + +## Depends on + + + +## Issues + + + +## Changelog + +- Upgraded dependency from 1.0 to 1.1 +- Ripped out `oldFunction()` +- Combined `file1` and `file2` + +## Tophatting + + From 6fc4d12ca9680ebbaf143021570c9535ef5eef4a Mon Sep 17 00:00:00 2001 From: taimoor ahmad <139589712+taimoor-at-opslevel@users.noreply.github.com> Date: Wed, 13 Sep 2023 18:00:46 -0400 Subject: [PATCH 2/4] Update pull_request_template.md --- .github/pull_request_template.md | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index e2697d55..a06d24f6 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -16,6 +16,12 @@ - Ripped out `oldFunction()` - Combined `file1` and `file2` +## Follow up items + +- [ ] Update this other repo +- [ ] Make a post in `#demo` +- [ ] Failover some service + ## Tophatting From 0f019574ab39c1cde2e5d81b6e5db3e77c4ddb60 Mon Sep 17 00:00:00 2001 From: taimoor ahmad <139589712+taimoor-at-opslevel@users.noreply.github.com> Date: Thu, 14 Sep 2023 19:08:55 -0400 Subject: [PATCH 3/4] template feedback --- .github/pull_request_template.md | 17 ++++++----------- 1 file changed, 6 insertions(+), 11 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index a06d24f6..85616059 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -10,18 +10,13 @@ -## Changelog +## Proposed changes/checklist -- Upgraded dependency from 1.0 to 1.1 -- Ripped out `oldFunction()` -- Combined `file1` and `file2` - -## Follow up items - -- [ ] Update this other repo -- [ ] Make a post in `#demo` -- [ ] Failover some service +- [ ] Develop X, replace Y with Z, optimize A and B... +- [ ] Update the examples and documentation we have +- [ ] Ensure test coverage is the same/better than before +- [ ] Make a `changie` entry ## Tophatting - + From 093c2be1b25f491657aef2cbf37e3f620aadb675 Mon Sep 17 00:00:00 2001 From: Taimoor Ahmad Date: Mon, 25 Sep 2023 17:27:18 -0400 Subject: [PATCH 4/4] make way simpler --- .github/pull_request_template.md | 18 ++++-------------- 1 file changed, 4 insertions(+), 14 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 85616059..45a26a52 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -1,22 +1,12 @@ -## TL;DR - - - -## Depends on - - - ## Issues - + -## Proposed changes/checklist +## Changelog -- [ ] Develop X, replace Y with Z, optimize A and B... -- [ ] Update the examples and documentation we have -- [ ] Ensure test coverage is the same/better than before +- [ ] List your changes here - [ ] Make a `changie` entry ## Tophatting - +