Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Light property missing from items-builder. #552

Open
RobinLefebvre opened this issue Jan 11, 2022 · 0 comments
Open

Light property missing from items-builder. #552

RobinLefebvre opened this issue Jan 11, 2022 · 0 comments
Labels
area/application Task related to orcpub application itself bug Something isn't working

Comments

@RobinLefebvre
Copy link

Motivation / Use Case
Opened after checking with a user on some item issue.
Inability to create a custom weapon with the light property which looks to have been forgotten.

Expected Behavior

We want to have a way for item-builder with type weapon / subtype custom to have a checkbox for toggle of the Light property on the weapon.

Other Information

  • weapons.cljc -> already hardcodes the light? field for the base weapons, but the schema.clj for weapons doesn't have the boolean.
  • views.cljs -> Addition of the checkbox here. base-weapon-selector function is where it goes.
  • events.cljs -> should include the new reg-event-db, similar to the way we operate for the reach? boolean
  • subs.cljs -> should include the new reg-sub for event sub
  • magic-item.cljc -> the from-internal-item function should handle the field.

I don't have access to a dev environment for testing, but I'm pretty confident that should do the trick.
In an ideal world we'd have the properties displayed regardless of the selected type and we would have the ability to mock around with them. Which requires a quick rewrite of the views.cljs logic for display.

@datdamnzotz datdamnzotz added area/application Task related to orcpub application itself bug Something isn't working labels Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/application Task related to orcpub application itself bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants