Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

assemble all talks (1.html, 2.html) in a separate directory #12

Open
tusharnankani opened this issue Feb 15, 2023 · 3 comments
Open

assemble all talks (1.html, 2.html) in a separate directory #12

tusharnankani opened this issue Feb 15, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@tusharnankani
Copy link
Member

The root of the repo already looks a little too much, it would be better if we place them in directory specifically for this.

The only problem I see will be the URL becoming something like:

talks.ourtech.community/talk/1

@HarshKapadia2
Copy link
Member

HarshKapadia2 commented Feb 15, 2023

The problem you started is exactly why I've not said anything about those files in the root. As the repo grows though, it will become really very messy, so yes, we need to do something about it.

What we can do is to add a build script with GitHub Actions or just use GitHub Actions, to change file locations on build.

@HarshKapadia2 HarshKapadia2 added the enhancement New feature or request label Feb 15, 2023
@tusharnankani
Copy link
Member Author

The only problem I see will be the URL becoming something like:

talks.ourtech.community/talk/1

Can be fixed by making a simple server and redirecting to the path /1

@HarshKapadia2
Copy link
Member

Adding a server and adding a build script are VERY different decisions and is not a trivial thing. It might be trivial for OTC, but not for an established project and we should think like an established project. I don't think a web server is required for something so simple.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants