Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standardized Streamflow Index and Standardized Groundwater level Index #1877
base: main
Are you sure you want to change the base?
Standardized Streamflow Index and Standardized Groundwater level Index #1877
Changes from 3 commits
d8e2415
15a86d9
51f01ed
5c9a11d
3e2e840
59bfcfb
ee91fcc
dad3889
fe4f552
fe501a8
f2fde02
fc180f6
610962b
97ee37a
f10e18c
a0a4309
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SarahG-579462 @coxipi
I couldn't find any other reference to test against for SSI (same for SGI I think). I could only replicate two conditions out of many. When the values get too far from zero,
standaRdized
outputs lots of NaNs and the non-NaNs are far away from us. Also in these replicable values, the offset is somewhat constant.It looks like the problem is on their side?
Do you think this is still a valuable test then?
I'll also add a couple tests against ourselves.